Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] bump typescript-eslint to v6 #684

Open
tasshi-me opened this issue Jul 14, 2023 · 1 comment
Open

[Feature Request] bump typescript-eslint to v6 #684

tasshi-me opened this issue Jul 14, 2023 · 1 comment

Comments

@tasshi-me
Copy link
Collaborator

Why

Originally kintone/js-sdk#2177 by @Lorenzras.

The typescript-eslint v6 has been released, and there are many improvements and breaking changes.
https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/

@sajikix
Copy link
Contributor

sajikix commented Jul 20, 2023

There are many improvements in v6 and it should be done!

However, as @mshrtsr mentioned, typescript-eslint v6 has major changes to the config and rulesets. The @typescript-eslint/recommended ruleset (currently used in this config) also has many rules added, removed, or moved to other rulesets.

Proposal

So I think it would be better to divide it into 2 steps as follows.

  1. update the rules to be the same as they were in v5 as much as possible.
  • Disable all rules newly added to recommended in v6.
  • Conversely, rules that were removed from recommended in v6 or moved to other rulesets will be activated individually. (except for those that have been completely deleted).
  1. having completed 1, discuss the following again
  • Which rules in the newly recommended added should be activated?
  • Should we delete rules that have been removed from recommended?
  • New ruleset stylistic were created with v6, should they be enabled?

We can do 1 and 2 at the same time, but if users want to update to v6 quickly, I think it is better to do only 1 first and propose/discuss 2 at a later time.

How do you think we should proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants