Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update typescript-eslint monorepo to v6 (major) #681

Merged
merged 3 commits into from
Jul 24, 2023
Merged

fix(deps): update typescript-eslint monorepo to v6 (major) #681

merged 3 commits into from
Jul 24, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 10, 2023 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@typescript-eslint/eslint-plugin ^5.59.11 -> ^6.1.0 age adoption passing confidence
@typescript-eslint/parser ^5.59.11 -> ^6.1.0 age adoption passing confidence

Release Notes

typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)

v6.1.0

Compare Source

Bug Fixes
  • eslint-plugin: [comma-dangle] fixed crash from undefined predicate.ignore (#​7223) (d368164)
  • eslint-plugin: [no-floating-promises] false negative calling .then with second argument undefined (#​6881) (606a52c), closes #​6850
  • eslint-plugin: [no-floating-promises] finally should be transparent to unhandled promises (#​7092) (2a4421c)
  • eslint-plugin: [no-unnecessary-type-constraint] correctly fix in cts/mts files (#​6795) (1404796)
  • eslint-plugin: [no-unused-vars] check if any variable definition is exported (#​6873) (587ac30), closes #​6188
  • eslint-plugin: fix schemas across several rules and add schema tests (#​6947) (dd31bed)
  • eslint-plugin: include the rules types in the package (#​7215) (a3da11d)
Features
  • typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#​6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

v6.0.0

Compare Source

Bug Fixes
  • bumped ts-api-utils to 0.0.39 (#​6497) (217c710)
  • correct handling of additionalProperties in object schemas (#​6939) (489c7a5)
  • correct lint error after merge (277fdb5)
  • eslint-plugin: [explicit-module-boundary-types] remove shouldTrackReferences option from schema (#​5399) (6d32734)
  • eslint-plugin: allow parser@^6.0.0 (#​6630) (92908bd)
  • eslint-plugin: remove valid-typeof disable in eslint-recommended (#​5381) (b82df5e)
  • fix illegal decorator check (#​6723) (c456f8c)
  • rename typeParameters to typeArguments where needed (#​5384) (08d757b)
  • replace tsutils with ts-api-tools (#​6428) (79327b4)
  • type-utils: treat intrinsic types as if they are from lib and never match error types (#​6869) (ecb57de)
  • typescript-estree: account for namespace nesting in AST conversion (#​6272) (09e3877)
  • update exports field in package.json files (#​6550) (53776c2)
chore
Features
BREAKING CHANGES
  • eslint-plugin: Adds an additional class of checks to the rule
  • drop support for ESLint v6
  • drops support for node v17
  • Bumps the minimum supported range and removes handling for old versions
  • drops support for node v12

You can read about our versioning strategy and releases on our website.

v5.62.0

Compare Source

Bug Fixes
  • eslint-plugin: [comma-spacing] allow no space after trailing comma in objects and arrays (#​6938) (24bdacc)
  • eslint-plugin: [prefer-includes] escape special characters (#​7161) (5a347a5), closes #​7145
  • eslint-plugin: replace auto-fix of class literal property style rule with suggestion (#​7054) (a8c824a)
Features
  • eslint-plugin: [prefer-nullish-coalescing] add ignorePrimitives option (#​6487) (6edaa04)

You can read about our versioning strategy and releases on our website.

v5.61.0

Compare Source

Features

You can read about our versioning strategy and releases on our website.

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v5.60.1

Compare Source

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

v5.60.0

Compare Source

Features
  • eslint-plugin: [restrict-plus-operands] add allow* options (#​6161) (def09f8)

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.9 (2023-06-05)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.8 (2023-05-29)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.7 (2023-05-22)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.6 (2023-05-15)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.5 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.4 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.3 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.2 (2023-05-01)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.1 (2023-04-24)

Bug Fixes
  • eslint-plugin: [prefer-regexp-exec] skip malformed regexes (#​6935) (05ed60e)
  • eslint-plugin: [unified-signatures] no parameters function (#​6940) (2970861)
typescript-eslint/typescript-eslint (@​typescript-eslint/parser)

v6.1.0

Compare Source

Features
  • typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#​6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

v6.0.0

Compare Source

Bug Fixes
chore
Features
BREAKING CHANGES
  • drop support for ESLint v6
  • drops support for node v17
  • drops support for node v12

You can read about our versioning strategy and releases on our website.

v5.62.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

v5.61.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

v5.60.1

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

v5.60.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/parser

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/parser

5.59.9 (2023-06-05)

Note: Version bump only for package @​typescript-eslint/parser

5.59.8 (2023-05-29)

Note: Version bump only for package @​typescript-eslint/parser

5.59.7 (2023-05-22)

Note: Version bump only for package @​typescript-eslint/parser

5.59.6 (2023-05-15)

Note: Version bump only for package @​typescript-eslint/parser

5.59.5 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/parser

5.59.4 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/parser

5.59.3 (2023-05-08)

Note: Version bump only for package @​typescript-eslint/parser

5.59.2 (2023-05-01)

Note: Version bump only for package @​typescript-eslint/parser

5.59.1 (2023-04-24)

Note: Version bump only for package @​typescript-eslint/parser

Configuration

📅 Schedule: Branch creation - "after 9pm,before 9am" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Jul 10, 2023
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from c7a89bb to 9cf5876 Compare July 17, 2023 19:36
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 9cf5876 to ce2cb74 Compare July 19, 2023 13:46
@koba04 koba04 added the help wanted Extra attention is needed label Jul 21, 2023
@sajikix
Copy link
Contributor

sajikix commented Jul 24, 2023 •
edited

fix #684

As per this issue, I changed the configuration file for compatibility with v5.

@renovate
Copy link
Contributor Author

renovate bot commented Jul 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

koba04
koba04 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sajikix
Thank you for your great work! 👍

I have a question.
This doesn't include any breaking change, does it? It means that users won't see any new errors after updating cybozu/eslint-config.

@sajikix
Copy link
Contributor

sajikix commented Jul 24, 2023

@koba04

This doesn't include any breaking change, does it? It means that users won't see any new errors after updating cybozu/eslint-config.

Basically, users will not see any errors as a result of this update. However, if you are using a very old TypeScript(< 4.2.4), you may see errors. Whether this is a BREAKING CHANGE or not is a difficult question... 🤔

More about BreakingChages of ts-eslint v6

There are 5 Rule Breaking Changes in this v6 update.

https://typescript-eslint.io/blog/announcing-typescript-eslint-v6#rule-breaking-changes

There are no rules enabled by cybozu/eslint-config in this list, so there should be no errors due to rule behavior changes.

So, the only concern is that v6 dropped support for typescript versions lower than v4.2.4. (Similarly, ts-eslint v6 drops support for Node v12 and v14 and ESLint v6 , but there is no problem.)

https://typescript-eslint.io/blog/announcing-typescript-eslint-v6#tooling-breaking-changes

Following this, I also changed the peerDependencies in cybozu/eslint-config to require typescript v4.2.4 or higher.
It's unlikely, but users using versions lower than v4.2.4 of typescript will see the error.

@koba04
Copy link
Contributor

koba04 commented Jul 24, 2023

Basically, users will not see any errors as a result of this update. However, if you are using a very old TypeScript(< 4.2.4), you may see errors. Whether this is a BREAKING CHANGE or not is a difficult question... 🤔

Thank you for elaborating this! We generally treat the kind of change as a breaking change, so let's ship this as a breaking change 👍 We don't have to hesitate to release a new major version 👍

@koba04 koba04 merged commit 4f2e116 into master Jul 24, 2023
8 checks passed
@koba04 koba04 deleted the renovate/major-typescript-eslint-monorepo branch July 24, 2023 10:39
@sajikix sajikix mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@sosukesuzuki sosukesuzuki Awaiting requested review from sosukesuzuki sosukesuzuki is a code owner

Assignees
No one assigned
Labels
help wanted Extra attention is needed renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sajikix @koba04