Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Use eslint-plugin-n instead of eslint-plugin-node #743

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sajikix
Copy link
Contributor

@sajikix sajikix commented Feb 26, 2024

Why

eslint-plugin-node has not been maintained for a long time. It is now forked and maintained by the eslint-community under the name eslint-plugin-n.

Considering the future maintainability and FlatConfig support, it is better to use eslint-plugin-n.

What

  • eslint-plugin-node is uninstalled and eslint-plugin-n is installed instead.
  • Use eslint-plugin-n's rule and config
  • update test
  • update README

@sajikix
Copy link
Contributor Author

sajikix commented Feb 29, 2024

With v16 of eslint-plugin-n, ts file resolution fails and wrong errors are reported in n/no-missing-import rule. This bug will be fixed in v17 of eslint-plugin-n, so I will update when it is officially released. (v17 is pre-release as of 2024/02/29.)

Reference: PR to fix this bug

@sajikix sajikix marked this pull request as draft February 29, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant