Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import run/adapt from lib/cjs instead of lib #749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mightyiam
Copy link

No description provided.

@staltz
Copy link
Member

staltz commented Nov 20, 2017

Hi @mightyiam, thank you for taking your time to send us this PR. We appreciate it, but have you noticed that adapt.ts is anyway compiled to lib/adapt.js?

"postlib": "cp lib/cjs/adapt.* lib/"

This was a measure we did in order to avoid the breaking change.

@mightyiam
Copy link
Author

@staltz sorry, I should have commented on this PR. Here, this is what this is about: #744 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants