Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add required modules for babel/jsx to npm install. #774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docs: add required modules for babel/jsx to npm install. #774

wants to merge 1 commit into from

Conversation

bloodyKnuckles
Copy link
Contributor

I needed to also install babel-cli and babel-preset-es2015 to run a basic jsx example. In fact I also need babelify since I was using browserify, but didn't add that to the example since the bundler is not specified.

I needed to also install babel-cli and babel-preset-es2015 to run a basic jsx example. In fact I also need babelify since I was using browserify, but didn't add that to the example since the bundler is not specified.
@staltz
Copy link
Member

staltz commented Jan 29, 2018

Hi :)
Thanks for submitting this PR, superficially it looks correct. Before merging this PR I think we need someone else to confirm that this is a normal requirement when using Babel.

@staltz staltz changed the title Add required modules for babel/jsx to npm install. Docs: add required modules for babel/jsx to npm install. Jan 29, 2018
@jvanbruegge
Copy link
Member

It looks ok, but I wouldnt advertise snabbdom-jsx in the docs. It's buggy and unmaintained. Snabbdom-pragma works a lot better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants