New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples menu document #880

Open

janat08 wants to merge 1 commit into cyclejs:master from janat08:documentExamples

janat08 commented Mar 24, 2019 •

edited

###--------------------------------------------------------###
docs(examples): examples menu document

Surmised various example applications, and described principles demonstrated in simple examples.

ISSUES CLOSED: #480
###--------------------------------------------------------###

Member

staltz commented Mar 25, 2019

Hi @janat08 :)
Thanks for submitting this PR, we appreciate the desire to help. Before merging this PR could you notice and fix typos in the readme text, and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

staltz reviewed

View reviewed changes

examples/basic/jsx-seconds-elapsed/src/main.js Outdated Show resolved Hide resolved

janat08 force-pushed the documentExamples branch 2 times, most recently from 13d717a to c1af58a Compare

March 25, 2019 18:55

Author

janat08 commented Mar 25, 2019

I was hoping to get the bounty from issuehunt, even if the issue was meant for commenting the code.

staltz reviewed

View reviewed changes

examples/README.md Outdated Show resolved Hide resolved

janat08 force-pushed the documentExamples branch from 4311f4d to 9ac7121 Compare

March 28, 2019 01:42

jopek reviewed

View reviewed changes

jopek left a comment

👍

Member

staltz commented Apr 26, 2019

I guess I'm waiting for this step before merging:

and then rewrite the commit message so that it conforms to the commit convention? (You probably saw a note about this in the PR template)

:)


          Examples menu document

13d35ef

###--------------------------------------------------------###
docs(examples): examples menu document

Surmised various example applications, and described principles demonstrated in simple examples.

ISSUES CLOSED: cyclejs#480
###--------------------------------------------------------###

janat08 force-pushed the documentExamples branch from 9ac7121 to 13d35ef Compare

April 26, 2019 13:28

Author

janat08 commented Apr 26, 2019

Thanks for clarification. I use gitkraken gui app, so neither the pull or commit templates showed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment