Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window driver #883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

window driver #883

wants to merge 1 commit into from

Conversation

janat08
Copy link

@janat08 janat08 commented Apr 12, 2019

  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit

###--------------------------------------------------------###
feat(dom): window driver for events

Window driver following examples set in dom driver for domsource and etc. Has no documentation as it
was metioned that this might go into repository of its own rather than official one at first.

BREAKING CHANGE:
none

ISSUES CLOSED: #568
###--------------------------------------------------------###

###--------------------------------------------------------###
feat(dom): window driver for events

Window driver following examples set in dom driver for domsource and etc. Has no documentation as it
was metioned that this might go into repository of its own rather than official one at first.

BREAKING CHANGE:
none

ISSUES CLOSED: cyclejs#568
###--------------------------------------------------------###
@janat08 janat08 changed the title WIP: window driver window driver Apr 12, 2019
@janat08
Copy link
Author

janat08 commented Apr 12, 2019

For some reason there're CI errors on lint, whereas on local it errors on a bunch of packages. I had karma working week before, and now it's not anymore with Error: You need to include some adapter that implements __karma__.start method. From what I remember those tests indeed pass. I couldn't get special handler for resize events to work with strict types.

@janat08
Copy link
Author

janat08 commented Apr 12, 2019

Do you want this a separate package?

@janat08
Copy link
Author

janat08 commented Apr 27, 2019

id rather use cypress or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read window events through some driver
1 participant