[Cycle.js Neo] The new DOM driver #969
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the calls to the helper factory have been marked as PURE, so that optimizer like terser can drop the usused hyperscript helpers
|
Rendering already works, even dynamic content, but no event handlers or isolation yet |
This implements the basic event delegation for bubbling events. It already takes total and sibling isolation into account, but is currently still lacking the ability to simulate the capture phase. It also does not take non-bubbling listeners into account at the moment.
staltz
reviewed
Oct 23, 2021
This makes it easier to use `isolate()` with a single string as argument instead of providing an isolation scope per driver. In general this should be allowed for all drivers and by convention, a simple string should default to the tightest, ie total, isolation.
If the user does not use a master wrapper like @cycle/state, they no longer have to manually pass an empty array to `run`.
Before this change, if an element was updated or added, only the new element would be notified to the user, not the updated result of their query
jvanbruegge
force-pushed
the
neo-dom
branch
3 times, most recently
from
53f1b8d
to
fa7af78
Compare
Before this, when an elementListener was added and the elements it listens to were patched afterwards, the user would be notified twice. Now there is only one `patch` per animation frame and the user is only notified once
As one id is generated for every event, using a number would lead to a wrap-around of ids. This might lead to very subtle bugs for long running applications. As we are only incrementing the ids by one and not do any arithmetic on them, using bigint does not create any performance impact
|
Nice to see progress! 😊 |
|
Yeah, I caught corona and what else would I do 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.