Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf from pre-release to 3.12.1 #3623

Merged
merged 1 commit into from
May 26, 2020

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented May 25, 2020

This is a small change with no associated Issue.

Change from Protobuf pre-release #3594 to 3.12.1.
Compile with new resulted in no change:

(flow) sutherlander@cortex-vbox:flow$ protoc --experimental_allow_proto3_optional -I=./ --python_out=./ data_messages.proto
(flow) sutherlander@cortex-vbox:flow$ git status
On branch protobuf-3.12.1
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   ../../setup.py

no changes added to commit (use "git add" and/or "git commit -a")
(flow) sutherlander@cortex-vbox:flow$ protoc --version
libprotoc 3.12.1

One review will probably do.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Already covered by existing tests.
  • No change log entry required.
  • No documentation update required.

@dwsutherland dwsutherland added this to the cylc-8.0a2 milestone May 25, 2020
@dwsutherland dwsutherland self-assigned this May 25, 2020
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI happy, LGTM

@kinow
Copy link
Member

kinow commented May 25, 2020

Leaving it up to @oliver-sanders or @hjoliver to do the final review/merge.

@dwsutherland
Copy link
Member Author

Leaving it up to @oliver-sanders or @hjoliver to do the final review/merge.

A one liner, and all tests passed.. But sure, no harm in waiting (not like alpha2 is going in tonight)..

@hjoliver hjoliver merged commit e9f6e27 into cylc:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants