-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolated start-up and shut-down graphs. #5090
Open
hjoliver
wants to merge
2
commits into
cylc:master
Choose a base branch
from
hjoliver:initial-final-graph
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
initial-final-graph
branch
from
August 22, 2022 07:41
e9ee0ee
to
b4e5429
Compare
This was referenced Sep 14, 2022
hjoliver
force-pushed
the
initial-final-graph
branch
5 times, most recently
from
September 26, 2022 03:46
bcb5b05
to
8d09900
Compare
hjoliver
changed the title
No-cycle start-up and shut-down graphs.
Isolated start-up and shut-down graphs.
Sep 26, 2022
I'm tentatively putting this one back to 8.1.0.
|
Merged master and deconflicted. |
@dpmatthews - pinging you for a big-picture review (given your involvement in the discussions that led to this). |
1 task
hjoliver
force-pushed
the
initial-final-graph
branch
from
March 19, 2023 21:33
acc0ca3
to
5c4532c
Compare
Squashed and rebased. |
hjoliver
force-pushed
the
initial-final-graph
branch
from
March 19, 2023 21:46
5c4532c
to
5617b1c
Compare
hjoliver
force-pushed
the
initial-final-graph
branch
from
April 26, 2023 04:13
5617b1c
to
2eb2cde
Compare
(Rebased) |
hjoliver
force-pushed
the
initial-final-graph
branch
from
July 28, 2023 03:31
2eb2cde
to
f6ebfbf
Compare
(Rebased) |
commit ad8231a8f22dd3cd8d887774474f97df2c83e429 Merge: acc0ca3 6fc3c58 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Mon Mar 20 10:27:19 2023 +1300 Merge branch 'master' into initial-final-graph commit acc0ca3 Author: Hilary Oliver <hilary.j.oliver@gmail.com> Date: Wed Oct 26 12:00:00 2022 +1300 Style fix. commit a7170fb Author: Hilary Oliver <hilary.j.oliver@gmail.com> Date: Wed Oct 26 11:53:31 2022 +1300 Update change log. commit 9024065 Merge: 858a8c1 b0ff549 Author: Hilary Oliver <hilary.j.oliver@gmail.com> Date: Wed Oct 26 11:32:26 2022 +1300 Merge branch 'master' into initial-final-graph commit 858a8c1 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Mon Sep 26 23:27:01 2022 +1300 Fix alpha/omega graph runahead release. commit b581ab2 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Mon Sep 26 23:26:33 2022 +1300 Add new func tests. commit 8d09900 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Mon Sep 26 15:53:42 2022 +1300 Revert graph sorting change. commit 75c1763 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Fri Sep 23 22:44:08 2022 +1200 Adapt integration tests. commit 1b685a0 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Fri Sep 23 15:55:57 2022 +1200 Tidy up. commit 7a62450 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Fri Sep 23 13:20:51 2022 +1200 Switch to alpha and omega. commit 129c2e3 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Fri Sep 23 10:32:54 2022 +1200 Implicit integer ICP if only nocycle graphs. commit a53ac82 Author: Hilary James Oliver <hilary.j.oliver@gmail.com> Date: Thu Sep 22 16:23:16 2022 +1200 startup and shutdown graphs; needs tidying
hjoliver
force-pushed
the
initial-final-graph
branch
from
September 4, 2023 05:51
f6ebfbf
to
db03e50
Compare
(Rebased) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4912
Supersede #5036
(Really addresses the original #4903 but specifically just for start-up and shut-down graphs)
Implements isolated initial and final graphs as special non-advancing cycle points, to avoid the pain of eternal dependence on initial and final tasks.
The initial cycle point is called alpha and the final one omega.
How it works:
Also:
alpha/foo
will coexist in the task pool with3/bar
etc.EXAMPLE
Result:
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users