Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Radio component #370

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add Radio component #370

wants to merge 12 commits into from

Conversation

ax-vasquez
Copy link

No description provided.

Copy link

changeset-bot bot commented Jan 16, 2024

⚠️ No Changeset found

Latest commit: 04fa74d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ax-vasquez ax-vasquez marked this pull request as draft January 16, 2024 21:31
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cypress-design ❌ Failed (Inspect) Feb 7, 2024 1:05pm

Copy link

cypress bot commented Jan 17, 2024

Passing run #1879 ↗︎

0 1 0 1 Flakiness 0

Details:

Merge 04fa74d into 73d9048...
Project: cypress-design Commit: fd648df5e0 ℹ️
Status: Passed Duration: 00:15 💡
Started: Feb 7, 2024 1:09 PM Ended: Feb 7, 2024 1:09 PM

Review all test suite changes for PR #370 ↗︎

@ax-vasquez
Copy link
Author

@elevatebart @ryanjwilke I've been asked to put a hold on this to make sure the related Cloud work goes out first. Unfortunately, this will mean I need to rely on our current, ad-hoc radio design instead of using this shared one.

However, the styles of the base radio don't look too far off from what we see in Figma. Just wanted to let you know in case this PR doesn't get touched for a bit. I intend to circle back to this once I finish my current sprint work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants