fix: slightly increase color contrast of gray-600 to meet 4.5:1 a11y standard on white backgrounds #434
Conversation
🦋 Changeset detectedLatest commit: bdae906 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jennifer-shehane
changed the title
jennifer-shehane
changed the title
Passing run #2169 ↗︎
Details:
Review all test suite changes for PR #434 ↗︎ |
|||||||||||||||
jennifer-shehane
changed the title
There was a problem hiding this comment.
I would caution against fixing our color contrast issues by changing the color. I mentioned this is Slack, but the new standard the team has shifted to is to just use gray-700 in our designs instead. We used gray-600 sometimes in the past before we paid too much attention to a11y requirements, but we shifted to using gray-700 in most scenarios about a year ago.
|
@ryanjwilke It is a slightly bigger shift in color to gray-700 than the slight change here. But I'm ok updating to gray-700 for these uses if that's the suggestion. Honestly we have a lot more uses of gray-500 on white backgrounds in the App, so I'm not sure the approach with those either. Today's gray-600
gray-600 in this PR
gray-700
|
|
@jennifer-shehane Yep, I figured this might be for resolving a text contrast issue. I would suggest to use |
The gray-600 color does not meet the a11y standard of 4.5:1 color contrast ratio on white backgrounds. This updates the color slightly to get it there so that this can be used as a back light gray color for designs within Cypress that meets the standard.
Example of violation within Cypress App.
Before
After
Before
After