Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .env support node >= 18.19 for security scans #1051

Closed

Conversation

dodtsair
Copy link

See issue #1050

Target branch is wrong not sure how to fix this.
Need to update circleci file

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@dodtsair
Copy link
Author

I thinks someone else would need to update the target branch to 12.17.3-node-18.20.2-publish based off 12.17.3-node-18.16.1-publish

@jennifer-shehane
Copy link
Member

@dodtsair What is the intention of this change? And merging it back into our cypress-docker-images?

@dodtsair
Copy link
Author

@jennifer-shehane

Per #1050 adding support for >= node-18.19 to in part grant access to --import provided by nodejs versions of that level.

@jennifer-shehane
Copy link
Member

@dodtsair I think the feature branch is odd because you branched off of a branch instead of master.

@MikeMcC399
Copy link
Collaborator

@dodtsair

There are multiple issues with this PR and it would be cleaner to start a new one after agreeing on the process, so I am closing it:

  • The PR is not based on the master branch (59 commits behind)
  • It does not target an appropriate feature branch (12.17.3-node-18.16.1-publish is not the right one)

I hope to get a replacement PR set up and

@MikeMcC399 MikeMcC399 closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants