Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated new-spec-added-confirmation.png and spec-list-with-new-spec.png #5824

Conversation

Oliver-Looney
Copy link
Contributor

@Oliver-Looney Oliver-Looney commented May 9, 2024

Updated: https://docs.cypress.io/guides/end-to-end-testing/writing-your-first-end-to-end-test#Add-a-test-file

  1. Updated text that said default test would fail when it passes
  2. Updated screenshot showing default spec
  3. Updated surrounding screenshots to match cypress & chrome versions
Before After
Screenshot 2024-05-09 at 11 44 34 Screenshot 2024-05-09 at 11 44 45
Screenshot 2024-05-09 at 11 06 07 Screenshot 2024-05-09 at 11 06 51
Screenshot 2024-05-09 at 11 08 25 Screenshot 2024-05-09 at 11 07 57

Copy link

netlify bot commented May 9, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 63e7960

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor

@Oliver-Looney

You're right that this section is out of date!

Also the text has changed in the previous screen. It no longer says "Create new empty spec" and instead it says just "Create new spec", so it would make sense to also replace the screenshot for https://docs.cypress.io/img/guides/end-to-end-testing/writing-your-first-end-to-end-test/create-new-empty-spec.png.

image

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, it did used to do this, but we updated it since then since that was kind of an awful experience. Thanks for updating the docs!

@jennifer-shehane jennifer-shehane merged commit 7b3b58d into cypress-io:main May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants