Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update semantic-release to 21.1.2 #817

Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Mar 28, 2024

Issue

npm audit reports vulnerabilities. The following vulnerabilities come from the use of semantic-release@19.0.5

  • ip 2.0.0 Severity: moderate
  • semver 7.0.0 - 7.5.1 npm Severity: moderate

npm audit fix reports that these vulnerabilities cannot be fixed automatically.

Changes

The currently used version, semantic-release@19.0.5, was released in Aug 2022.

Update to semantic-release@21.1.2. This version has proved stable in the cypress-io/github-action where it is called through main.yml and cycjimmy/semantic-release-action.

Notes

Publishing takes place through CircleCI. The current workflow shows

release:
executor: cypress/default
steps:
- checkout
- run: npx semantic-release@19.0.3

The version used by CircleCI 19.0.3 was mismatched to the version updated by renovate to 19.0.5. This PR aligns them again to use a common version 21.1.2 version.

This PR uses a semantic commit fix: so that a new release will be generated when the PR is merged, so also testing that it works correctly.

The CircleCI pipelines are logged to https://app.circleci.com/pipelines/github/cypress-io/cypress-example-kitchensink.

The release job runs under Node.js 18.16.1. This is not compatible with semantic-release@22.0.0 and above which requires a minimum of Node.js 18.17.0. semantic-release@21.1.2 is the highest compatible version.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 28, 2024 10:24
@jennifer-shehane
Copy link
Member

Thanks!

@MikeMcC399 MikeMcC399 marked this pull request as draft March 28, 2024 19:12
@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 28, 2024 19:32
@jennifer-shehane jennifer-shehane merged commit 8a0cd80 into cypress-io:master Mar 29, 2024
10 checks passed
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the update/semantic-release branch March 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants