Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd end table for older versions of cypress #820

Merged
merged 1 commit into from Apr 2, 2024

Conversation

AtofStryker
Copy link
Contributor

Closes #819

Re-adds the end() table code so older versions of cypress with the scaffolded misc() tests continue to work

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for cypress-example-kitchensink ready!

Name Link
🔨 Latest commit 8662a5a
🔍 Latest deploy log https://app.netlify.com/sites/cypress-example-kitchensink/deploys/660c68689e46050009c0ef99
😎 Deploy Preview https://deploy-preview-820--cypress-example-kitchensink.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 2, 2024

Passing run #28038 ↗︎

0 123 0 0 Flakiness 0

Details:

fix: readd end table for older versions of cypress
Project: cypress-example-kitchensink Commit: 8662a5a600
Status: Passed Duration: 04:35 💡
Started: Apr 2, 2024 8:31 PM Ended: Apr 2, 2024 8:36 PM

Review all test suite changes for PR #820 ↗︎

@AtofStryker AtofStryker changed the title readd end table for older versions of cypress fix: readd end table for older versions of cypress Apr 2, 2024
Copy link

cypress bot commented Apr 2, 2024

Passing run #28037 ↗︎

0 123 0 0 Flakiness 0

Details:

Merge 8662a5a into ed6f760...
Project: cypress-example-kitchensink Commit: f9de878fbe ℹ️
Status: Passed Duration: 04:24 💡
Started: Apr 2, 2024 8:31 PM Ended: Apr 2, 2024 8:35 PM

Review all test suite changes for PR #820 ↗︎

@AtofStryker AtofStryker merged commit 55ef759 into master Apr 2, 2024
43 checks passed
@AtofStryker AtofStryker deleted the fix/readd_end_table_html branch April 2, 2024 20:37
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Contributor

@AtofStryker

You've fast-tracked this through to deployment on https://example.cypress.io/commands/misc I see. I checked that the backwards compatibility is fixed. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cy.end() test from earlier versions fails against example.cypress.io/commands/misc
4 participants