ci: cause skipped tests linting error #827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
eslint-plugin-mocha is configured inconsistently in this repo regarding the rules:
describe.only
,it.only
, etc. - configured toerror
describe.skip
,it.skip
, etc. - configured perplugin:mocha/recommended
forwarn
only (see Rules table) for this plugin.Since it is undesirable to have
.only
or.skip
in the example test specs, both should be configured toerror
on linting.Change
Add mocha/no-skipped-tests
error
to the configuration in .eslintrc.Verification
Temporarily modify the file
cypress/e2e/2-advanced-examples/actions.cy.js
to add an exclusive test and a skipped test:context
tocontext.only
it
toit.skip
and execute:
confirm that linting errors (no warnings) are reported: