fix(deps): update dependency parse-domain to version 2.3.4 🌟 (#5726)

* fix(deps): update parse-domain to 2.3.4 🌟 * update details now that s3.amazonaws.com is a public suffix * bump max size Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Zach Bloomquist <github@chary.us>
cypress-io · Nov 19, 2019 · 6bb3a48 · 6bb3a48 · cypress-bot · Nov 19, 2019
1 parent b03b25c
commit 6bb3a48
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/packages/driver/package.json b/packages/driver/package.json
@@ -52,7 +52,7 @@
     "moment": "2.24.0",
     "morgan": "1.9.1",
     "npm-install-version": "6.0.2",
-    "parse-domain": "2.0.0",
+    "parse-domain": "2.3.4",
     "setimmediate": "1.0.5",
     "sinon": "3.3.0",
     "strict-cookie-parser": "3.1.0",

diff --git a/packages/server/package.json b/packages/server/package.json
@@ -110,7 +110,7 @@
     "opn": "cypress-io/opn#2f4e9a216ca7bdb95dfae9d46d99ddf004b3cbb5",
     "ospath": "1.2.2",
     "p-queue": "6.1.0",
-    "parse-domain": "2.0.0",
+    "parse-domain": "2.3.4",
     "pluralize": "8.0.0",
     "pumpify": "1.5.1",
     "ramda": "0.24.1",

diff --git a/packages/server/test/integration/server_spec.coffee b/packages/server/test/integration/server_spec.coffee
@@ -1124,11 +1124,11 @@ describe "Server", ->
             origin: "https://s3.amazonaws.com"
             strategy: "http"
             visiting: false
-            domainName: "amazonaws.com"
+            domainName: "s3.amazonaws.com"
             fileServer: null
             props: {
-              domain: "amazonaws"
-              tld: "com"
+              domain: ""
+              tld: "s3.amazonaws.com"
               port: "443"
             }
           })
@@ -1199,10 +1199,10 @@ describe "Server", ->
               strategy: "http"
               visiting: false
               fileServer: null
-              domainName: "amazonaws.com"
+              domainName: "s3.amazonaws.com"
               props: {
-                domain: "amazonaws"
-                tld: "com"
+                domain: ""
+                tld: "s3.amazonaws.com"
                 port: "443"
               }
             })
diff --git a/scripts/binary/zip.coffee b/scripts/binary/zip.coffee
@@ -39,10 +39,10 @@ checkZipSize = (zipPath) ->
   stats = fs.statSync(zipPath)
   zipSize = filesize(stats.size, {round: 0})
   console.log("zip file size #{zipSize}")
-  MAX_ALLOWED_SIZE_MB = if os.platform() == "win32" then 245 else 150
+  MAX_ALLOWED_SIZE_MB = if os.platform() == "win32" then 245 else 160
   MAX_ZIP_FILE_SIZE = megaBytes(MAX_ALLOWED_SIZE_MB)
   if stats.size > MAX_ZIP_FILE_SIZE
-    throw new Error("Zip file is too large: #{zipSize} exceeds #{MAX_ZIP_FILE_SIZE}")
+    throw new Error("Zip file is too large: #{zipSize} (#{stats.size} bytes) exceeds #{MAX_ZIP_FILE_SIZE} bytes")
 
 # resolves with zipped filename
 linuxZip = (src, dest) ->