fix: XHR stub error if response json has number/boolean (#9107)

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
cypress-io · Nov 9, 2020 · dae76a8 · dae76a8 · cypress-bot · Nov 9, 2020
1 parent db85c3a
commit dae76a8
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 0 deletions.
diff --git a/packages/driver/cypress/fixtures/boolean.json b/packages/driver/cypress/fixtures/boolean.json
@@ -0,0 +1 @@
+true
diff --git a/packages/driver/cypress/fixtures/number.json b/packages/driver/cypress/fixtures/number.json
@@ -0,0 +1 @@
+14
diff --git a/packages/driver/cypress/integration/commands/xhr_spec.js b/packages/driver/cypress/integration/commands/xhr_spec.js
@@ -1780,6 +1780,36 @@ describe('src/cy/commands/xhr', () => {
 
         cy.contains('#result', '""').should('be.visible')
       })
+
+      it('works if the JSON file has number content', () => {
+        cy
+        .server()
+        .route({
+          method: 'POST',
+          url: '/test-xhr',
+          response: 'fixture:number.json',
+        })
+        .visit('/fixtures/xhr-triggered.html')
+        .get('#trigger-xhr')
+        .click()
+
+        cy.contains('#result', 14).should('be.visible')
+      })
+
+      it('works if the JSON file has boolean content', () => {
+        cy
+        .server()
+        .route({
+          method: 'POST',
+          url: '/test-xhr',
+          response: 'fixture:boolean.json',
+        })
+        .visit('/fixtures/xhr-triggered.html')
+        .get('#trigger-xhr')
+        .click()
+
+        cy.contains('#result', /true/).should('be.visible')
+      })
     })
 
     describe('errors', {

diff --git a/packages/server/lib/controllers/xhrs.js b/packages/server/lib/controllers/xhrs.js
@@ -61,6 +61,10 @@ module.exports = {
           data = ''
         }
 
+        if (_.isNumber(data) || _.isBoolean(data)) {
+          data = String(data)
+        }
+
         const chunk = Buffer.from(data, encoding)
 
         headers['content-length'] = chunk.length