Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6.0 - click event not firing when mouseup and mousedown are different elements #5578

Closed
kuceb opened this issue Nov 1, 2019 · 5 comments · Fixed by #5580
Closed

3.6.0 - click event not firing when mouseup and mousedown are different elements #5578

kuceb opened this issue Nov 1, 2019 · 5 comments · Fixed by #5580
Labels
type: regression A bug that didn't appear until a specific Cy version release

Comments

@kuceb
Copy link
Contributor

kuceb commented Nov 1, 2019

currently, if the same element does not receive both the mouseup and mousedown, we do not fire the click event

The correct behavior is to fire the click event to the commonAncestor element.

This is a regression introduced in 3.6.0
@kuceb kuceb mentioned this issue Nov 1, 2019
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Nov 1, 2019
@jennifer-shehane
Copy link
Member

This was causing an issue when testing our own Dashboard.

@jennifer-shehane jennifer-shehane added the type: regression A bug that didn't appear until a specific Cy version release label Nov 6, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 6, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 6, 2019

The code for this is done in cypress-io/cypress#5580, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@lukeapage
Copy link
Contributor

This is hitting us on quite a few tests while trying to upgrade to 3.6.0. Is there a plan to release soon? (am also blocked by critical issues in 3.5.0)

@kuceb
Copy link
Contributor Author

kuceb commented Nov 7, 2019

@lukeapage yes, we're working to get a 3.6.1 release out ASAP

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 8, 2019

Released in 3.6.1.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix not sending click event to proper element cypress-io/cypress
3 participants
@lukeapage @jennifer-shehane @kuceb