fix not sending click event to proper element

[kuceb]

• Closes 3.6.0 - click event not firing when mouseup and mousedown are different elements  #5578

User facing changelog

• fixed regression introduced in 3.6.0 causing an incorrect element to receive the click event during action commands.

Additional details

How has the user experience changed?

if the an element moves or does not receive both mouseup and mousedown during cy.click():

• <3.5.0: same element will always receive both events and therefore the click event (incorrect algorithm)
• 3.5.0: the element at the mouse coords will always receive the click event (incorrect algorithm)
• 3.6.0: the element at that received both mouseup and mousedown will receive the click event. otherwise it's not fired (incorrect algorithm)
• 3.6.1: the commonAncestor of mouseup and mousedown elements will receive the click event. (correct algorithm)

PR Tasks

• refactor manual testing code

• Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?
• [NA] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3477 • 0 • 46 • 0

---

Run details

Project	cypress
Status	Passed
Commit	ad52adb
Started	Nov 5, 2019 11:13 PM
Ended	Nov 5, 2019 11:17 PM
Duration	04:06 💡
OS	Linux Debian - 9.8
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

I've confirmed that this fixes the issue encountered in the Services repo.

[brian-mann]

turn these into cy.stub