New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unzipping progress goes to 200% #5967
Unzipping progress goes to 200% #5967
Comments
Experienced same issue with Cypress 3.8.0 on Windows 10 WSL Ubuntu |
😅 Yeah, that should not be happening. We have some tests around this, but no tests around the exact percentage display as far as I can tell. Can you run the install with debug mode mode and print the entire set of logs here? There are 2 pathways it could take for unzipping and this should tell us which pathway yours followed. |
Here is debug log from Windows 10 WSL Ubuntu |
Greg I'm a bit slow, did that take 14 minutes to unzip? I'm struggling to convince people to get it into our build cycles with a 4 minute (haven't checked the time since 3.8.0) unzip time. I'm assuming you're able to cache it between builds? |
😄 yea it is a long time - this was on WSL (file I/O takes longer) and also yes - it will cache after first install so you should only need to install once (per version at least). |
@GregLahaye @goodliff It does still unzip correctly, right? Just the progress indicator is wrong? |
If you guys can do me a favor and send me the output of The progress indicator works basically by counting the number of lines output and dividing that by the total number of file in the archive - it assumes 1 line per file output. But maybe there is some version of unzip that has different stdout conventions. My unzip:
And it looks fine: |
Wow! Have you sped that up for demonstration purposes? :) I'm just in the middle of something but when I'm free I'll try and get more information from docker (had to remove it from dependencies for the moment) |
Nope, it should be this fast if you have re: |
Quite possibly, it's running via docker-compose at the moment and I've tried adding unzip to that. I think it may be defaulting to the npm unzip, I believe we have that as a dev-dep.
I've chopped large bits out of this to make it more readable, I'm still working on getting -v on unzip but I'll have to rebuild which will take some time. Looking at docker-compose it doesn't mention unzip so I think you might be right. Off topic, I'm trying to workout whether a PR from 8 months ago got released, where is the best place to ask or should I just raise a ticket? |
Yep, looks like you're right, I installed the unzip via apt before the installation and it completed in 11 secs instead of the few minutes without it. It also calculated the progress correctly.
|
Same thing here - didn't have
Installing unzip through apt fixes the issue. |
Need anything else @flotwig? |
The code for this is done in cypress-io/cypress#6009, but has yet to be released. |
Released in 3.8.2 |
Tried the last release (3.8.0) on docker to check the the unzipping change that was introduced by cli: unnzip Cypress using
unzip
utility on Linux #5851, when downloading and extracting cypress I noticed that the unzipping progress continued to 200% and time remaining went into negative figures.Current behavior:
Desired behavior:
Ideally this would be accurate to the unzip progress.
Versions
Cypress package version: 3.8.0 | Cypress binary version: 3.8.0 | docker-compose version 1.24.1, build 4667896b
The text was updated successfully, but these errors were encountered: