-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Cypress from showing 200% unzip progress #6009
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, and I have finally added unit tests for this behavior
* Prevent unzipWithNode from getting called twice * fix unzip test * add unit test to check if unzip is called once * add unzip test for Darwin Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
User facing changelog
unzip
is not installed, the progress ofcypress install
would go to 200%.Additional details
unzipWithNode
was getting called twice, once when the error event fired and once when it closed.ditto
method always works on macOS.How has the user experience changed?
Now unzip won't say it's 200% complete when they don't have
unzip
installed. Also it will be faster since we won't be unzipping twice.PR Tasks