fix: Improve uncaught error handling #14826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
5 tasks
This was referenced Feb 12, 2021
Merged
chrisbreiding
changed the title
We now wrap timers in the AUT because if we do it in the driver/top frame, any uncaught errors thrown in the timer callbacks get picked up by the top frame's 'error' handler instead of the AUT's. We need to wrap the timer callbacks in the AUT itself for errors to propagate properly.
- refactor/consolidate the logic and the tests - add promise to uncaught:exception if it's an unhandled rejection
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
test was moved into reporter.errors.spec.js
in production/CI, the file is cypress_runner.js, so it doesn't work
it's covered by the isolated runner tests
flotwig
approved these changes
Feb 26, 2021
Comment on lines
+1
to
+8
| /** | ||
| * This is the entry point for the script that gets injected into | ||
| * the AUT. It gets bundled on its own and injected into the <head> | ||
| * of the AUT by `packages/proxy`. | ||
| * | ||
| * If adding to this bundle, try to keep it light and free of | ||
| * dependencies. | ||
| */ |
There was a problem hiding this comment.
i'm happy that this is no longer embedded as a string, good stuff
| // cause an 'uncaught:exception' event. This error will be caught in | ||
| // top.onerror with stack as 5th argument. | ||
| // fail the test | ||
| // cy.fail(err) |
There was a problem hiding this comment.
Suggested change
| // cy.fail(err) |
This was referenced Mar 1, 2021
15 tasks
5 tasks
tgriesser
added a commit
that referenced
this pull request
Apr 26, 2021
|
Hi @chrisbreiding is there an example of how to disable this? |
|
@zwass Yes, using the uncaught:exception event. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onunhandledrejectionas errors? #243User facing changelog
window.onerror.uncaught:exceptionevent with the promise as the third argument.Additional details
Instead of use
window.onerrorto catch uncaught errors, we now usewindow.addEventListener('error'). Before, if the app overwrotewindow.onerror, we would no longer catch any uncaught errors, but that's no longer the case.We also now use
window.addEventListener('unhandledrejection')to catch and fail if there's an unhandled promise rejection.How has the user experience changed?
If a user's app overwrote
window.onerroror had unhandled rejections, tests will fail that trigger errors/unhandled rejections. They will need to fix those errors in their app or return false fromuncaught:exceptionto get those tests to pass.PR Tasks
cypress-documentation? Uncaught exception handling updates cypress-documentation#3615type definitions?cypress.schema.json?