feat(issue-6229): added support for searching files using keyboard inputs based on OS #15388
Conversation
|
Thanks for taking the time to open a PR!
|
| } | ||
|
|
||
| _isMac () { | ||
| return (window.clientInformation['platform'] === 'MacIntel') |
There was a problem hiding this comment.
@jennifer-shehane in case you're wondering about this. It's a workaround of a known issue.
Manuel-Suarez-Abascal
changed the title
…press into feat/issue-6229
jennifer-shehane
changed the title
jennifer-shehane
changed the title
| onBlur={this._setBlur} | ||
| onChange={this._updateFilter} | ||
| onFocus={this._setFocus} |
There was a problem hiding this comment.
| onBlur={this._setBlur} | |
| onChange={this._updateFilter} | |
| onFocus={this._setFocus} | |
| onBlur={this._toggleFocus} | |
| onChange={this._updateFilter} | |
| onFocus={this._toggleFocus} |
There was a problem hiding this comment.
Same comment as above.
| onKeyUp={this._executeFilterAction} | ||
| /> | ||
|
|
||
| { window.addEventListener('keydown', this._executeSearch) } |
There was a problem hiding this comment.
The function is focusing the input when search keys are detected. Think this naming is a bit clearer of the function.
| { window.addEventListener('keydown', this._executeSearch) } | |
| { window.addEventListener('keydown', this._focusWhenSearchKeys) } |
There was a problem hiding this comment.
@jennifer-shehane I have addressed the comment & pushed the changes.
Great comments @jennifer-shehane I have addressed all of them & pushed the latest changes. I have retested the new feature & it seems everything to be working just fine. I'll be waiting for your next review & your confirmation on the functionality of |
|
Appears to work perfectly on Windows 👍
|
…uts based OS
User facing changelog
There's a new keyboard shortcut (
ctrl/cmd + f) to searchspecfiles in theTest Runnerbased on theuser's OS.Additional details
This PR allows users to perform a search for test files with the
ctrl/cmd + fcommand based on the Operating System. The file where the implementation was added iscypress\packages\desktop-gui\src\specs\specs-list.jsx. I used a method that uses the ternary operator & adds focus to the search input ifctrl/cmd + fis pressed. Then I called the method onkeydownon thewindowobject.How has the user experience changed?
filter-test-runner.mov
PR Tasks
issue-6269?