Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the type definition for cy.writeFile with 4 arguments. #15602

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

sainthkh
Copy link
Contributor

User facing changelog

Add the type definition for cy.writeFile with 4 arguments.

Additional details

  • Why was this change necessary? => 4 argument definition is valid, but it doesn't exist.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => N/A

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 22, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review March 22, 2021 03:12
@sainthkh sainthkh marked this pull request as draft March 22, 2021 03:12
@sainthkh
Copy link
Contributor Author

flaky failures.

@sainthkh sainthkh marked this pull request as ready for review March 22, 2021 03:20
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane merged commit a24d782 into cypress-io:develop Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cy.writeFile type does not have 4 argument version
2 participants