feat: change default headless size to 1920x1080

[kuceb]

BREAKING_CHANGE: changes default browser resolution from 1280x720 to 1920x1080, which may cause fullPage screenshots and video recordings to change size without configuration changes

• Closes Change default headless resolution to 1920x1080 #15752
• address Make the screenshot/video size configurable #587 (does not include api for window size)

User facing changelog

Bug fix: Electron and Firefox now respect screen resolution preferences set by the before:browser:launch event

• fix Setting Electron Dimensions Does Not Work In CI #15730
• fix cy.screenshot not respecting the viewport size on Firefox. #15481

Feat (BREAKING_CHANGE): Screen size for headless browsers is now a 1920x1080 by default making full page screenshots and videos resolutions consistent. To take advantage of this and ensure more consistent screenshot/video sizes, use the --headless flag when also specifying --browser

Additional details

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?
• Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

9394 • 0 • 119 • 3 • 1

---

Run details

Project	cypress
Status	Passed
Commit	3f4818e
Started	Apr 1, 2021 10:45 PM
Ended	Apr 1, 2021 10:56 PM
Duration	10:58 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

nice, good job normalizing all of these... puts us in a good spot to make this configurable later on too

[jennifer-shehane]

@bkucera I'd like some guidance after this goes in on whether these docs overrides are still appropriately documented - for how to override. I know some people have said they are completely unable in updating the Electron size within CI with our documented way. https://docs.cypress.io/api/plugins/browser-launch-api#Set-screen-size-when-running-headless

[kuceb]

@jennifer-shehane yes, this PR actually fixes that bug. I'll tag it as fixed

The base branch was changed.

[flotwig]

it's a mastapiece

[chrisbreiding]

We should only do this in run mode. In interactive mode, it's annoying to have electron maximize when it launches instead of being restored to its previous size and position.

[kuceb]

chrome launches maximized and I haven't heard many complaints about that

[chrisbreiding]

Maybe the first time you open it? If you close Cypress-launched Chrome and then open it again, it restores itself to the last size and position in which you used it. We manually store the Electron size and position, so that we can do the same, but this was making it maximize every time instead of being restored to the last used size and position.

[cypress-bot]

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.