Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass disable-dev-shm-usage flag to Electron #15825

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 6, 2021

User facing changelog

  • Fixed an issue that could cause Cypress to crash when running in Docker unless running with --ipc=host.

Additional details

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 6, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 6, 2021



Test summary

9492 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit c1e3df9
Started Apr 6, 2021 7:30 PM
Ended Apr 6, 2021 7:42 PM
Duration 11:46 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review April 6, 2021 19:43
@flotwig flotwig requested a review from a team as a code owner April 6, 2021 19:43
@flotwig flotwig requested a review from bahmutov April 6, 2021 19:43
@bahmutov
Copy link
Contributor

bahmutov commented Apr 6, 2021

Edited the Cypress v7.0.0 inside the Docker image and it solves the crash

@bahmutov bahmutov merged commit 1e06022 into develop Apr 6, 2021
Kocal added a commit to Yproximite/manala-recipes that referenced this pull request Apr 6, 2021
@flotwig flotwig deleted the fix-electron-shm branch January 24, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when running v7 in Docker using Electron Docker crashes when renderer process eats up too much memory
2 participants