Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make component testing windows compatible #15889

Merged
merged 6 commits into from
Apr 10, 2021
Merged

fix: make component testing windows compatible #15889

merged 6 commits into from
Apr 10, 2021

Conversation

elevatebart
Copy link
Contributor

User facing changelog

Repair the component testing build for windows

Additional details

  • Forked https://github.com/liximomo/lazy-compile-webpack-plugin to make it windows compatible (following liximomo's advice of the original PR)
  • Made relative paths of specs on windows use forward slash instead of backslash for POSIX compatible paths. Allowing the runner-ct to parse them on the front-end into directories.

How has the user experience changed?

Now Component Testing works on windows

@elevatebart elevatebart requested a review from a team as a code owner April 8, 2021 20:00
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 8, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 8, 2021 •
edited


Test summary

9492 • 0 • 111 • 3 • Flakiness 1

Run details
Project cypress
Status Passed
Commit fcae3b4
Started Apr 9, 2021 9:48 PM
Ended Apr 9, 2021 10:00 PM
Duration 12:34 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/retries.ui.spec.js 1 Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990
lmiller1990 reviewed Apr 9, 2021
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment... don't we have some way to run windows on CI? 🤔

npm/vue/${PWD}/cypress/plugins/index.js Outdated Show resolved Hide resolved
This was referenced Apr 9, 2021
Closed
Closed
@elevatebart
Copy link
Contributor Author

@lmiller1990 I believe we might be able to do that on AppVeyor.
CircleCI recently added it too.
I would still merge this without a test and figure out a way to test it in a future PR

@lmiller1990
Copy link
Contributor

@JessicaSachs @elevatebart this should be merged right, not closed?

@lmiller1990 lmiller1990 reopened this Apr 9, 2021
@lmiller1990 lmiller1990 self-requested a review April 10, 2021 00:02
@elevatebart elevatebart merged commit 602c762 into develop Apr 10, 2021
@lmiller1990 lmiller1990 mentioned this pull request Apr 12, 2021
Closed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Released in 7.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@flotwig flotwig Awaiting requested review from flotwig

@JessicaSachs JessicaSachs Awaiting requested review from JessicaSachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[7.0.0] Doesn't display list of specs in Cypress Component Test Runner
3 participants
@elevatebart @lmiller1990 @JessicaSachs