Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cy.select() correctly selects the option element with the value which has   #16196

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

sainthkh
Copy link
Contributor

User facing changelog

cy.select() correctly selects the option element with the value which has  

Additional details

  • Why was this change necessary? => cy.select() cannot select element when its option value has  .
  • What is affected by this change? => N/A
  • Any implementation details to explain? => I replaced all   with \u00a0.

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review April 27, 2021 01:48
@sainthkh sainthkh requested a review from a team as a code owner April 27, 2021 01:48
@sainthkh sainthkh requested review from flotwig and kuceb and removed request for a team April 27, 2021 01:48
@jennifer-shehane jennifer-shehane requested review from jennifer-shehane and removed request for flotwig April 27, 2021 13:01
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine I guess. It is an odd edge case and seems like many other characters could also fall in this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select('value') cannot contain round bracket ( ) as value
2 participants