Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle BigInt correctly. #16640

Merged
merged 3 commits into from May 26, 2021
Merged

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented May 24, 2021

User facing changelog

  • BigInt values are now printed correctly in the command log.

Additional details

  • Why was this change necessary? => BigInts were printed as {}. It's not expected.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => Added a case at our custom chai.inspect. It was manually patching the fix applied at chai@4.3.4 here

How has the user experience changed?

Before:
image

After:
image

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 24, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review May 25, 2021 06:20
@sainthkh sainthkh requested a review from a team as a code owner May 25, 2021 06:20
@sainthkh sainthkh requested review from chrisbreiding and kuceb and removed request for a team May 25, 2021 06:20
@sainthkh
Copy link
Contributor Author

flaky failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigint does not display correctly in Command Log, throws error on print to console of 0n
2 participants