fix: allow "localhost" in cy.intercept's RouteMatcher
#17068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
requested review from
chrisbreiding and
kuceb
and removed request for
a team
|
flaky failures. |
|
@sainthkh Zach is out of town for the week, so this review will be delayed til he gets back. I think he mentioned that this should be expanded a bit to include more than just "localhost", but I'm not sure exactly what he meant by that. |
flotwig
suggested changes
Jul 7, 2021
flotwig
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Allow "localhost" in
cy.intercept's RouteMatcher.Additional details
localhostis a valid hostname. But it became an error.How has the user experience changed?
N/A
PR Tasks