fix: empty state urls in navigation #20948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
emilyrohrbough
previously approved these changes
Apr 6, 2022
tbiethman
reviewed
Apr 7, 2022
packages/driver/src/cy/navigation.ts
Outdated
| @@ -25,6 +26,11 @@ export const historyNavigationTriggeredHashChange = (state): boolean => { | |||
| } | |||
|
|
|||
| const urls = state('urls') | |||
|
|
|||
| if (_.isEmpty(urls)) { | |||
There was a problem hiding this comment.
Let's explicitly check for a urlPosition value here too before continuing on. Your second spec asserts that it doesn't throw without a value, but the logic that follows isn't very meaningful without one.
tbiethman
approved these changes
Apr 8, 2022
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined (reading 'undefined')on cypress_runner.js #19749User facing changelog
n/a
Additional details
This issue occurs during url state changes and Cypress attempts to test the current url, but the state is empty.
How has the user experience changed?
Cypress stops randomly throwing this error and failing tests:
TypeError: Cannot read properties of undefined (reading 'undefined')PR Tasks
cypress-documentation?type definitions?cypress.schema.json?