Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass options to new private API of builtin mocha reporters. #21224

Closed
wants to merge 1 commit into from

Conversation

patcon
Copy link

@patcon patcon commented Apr 27, 2022

Addresses: #18014

First off, thanks for this wonderful tool! Sorry for not fully engaging with the really robust process you've laid out, but didn't want to be scared away by my lack of time to engage, and thought maybe someone else would carry it over the line 馃檹

Adding this even though not ready for review, so someone else can use-validate (in case it's helpful before I can make time for this process).


We're using a private internal mocha API, and it apparently broke:

this.reporter = new this.mocha._reporter(this.runner, {
reporterOptions: this.reporterOptions,
})

  • Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@patcon patcon requested a review from a team as a code owner April 27, 2022 13:37
@patcon patcon requested review from jennifer-shehane and removed request for a team April 27, 2022 13:37
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 27, 2022

Thanks for taking the time to open a PR!

@patcon patcon marked this pull request as draft April 27, 2022 13:37
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
Copy link
Member

@patcon Thanks for the contribution! Could you please sign our CLA?

We will need some tests written to verify this new behavior. No work can be merged into our project without tests.

There is a Contributing Guide that covers how to contribute and get Cypress running locally here: https://github.com/cypress-io/cypress/blob/develop/.github/CONTRIBUTING.md

Let us know if you have trouble getting the tests running locally.

@jennifer-shehane
Copy link
Member

@patcon Do you still have time to address the changes requested in this PR? We will have to close this PR due to inactivity otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants