Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grep): fix options sent to fast glob package - issue 27216 #27231

Merged

Conversation

samtsai
Copy link
Contributor

@samtsai samtsai commented Jul 7, 2023

Additional details

Though fast-glob 3.3.0 update exposes this error it's a consumer side concern.

The public interface of this package does not support a string as the value for the ignore option since 2018 year (release). I do not consider this issue a bug in my package. It is a problem on the consumer side.

See mrmlnc/fast-glob#404 (comment) for context

Steps to test

Ran:

yarn workspace @cypress/grep lint
yarn workspace @cypress/grep cy:run

How has the user experience changed?

PR Tasks

@cypress-app-bot
Copy link
Collaborator

@samtsai samtsai changed the title Fix issue 27216 fast glob error fix: issue 27216 fast glob error Jul 7, 2023
@samtsai samtsai force-pushed the fix-issue-27216-fast-glob-error branch from 5789f00 to 5d7461b Compare July 7, 2023 15:28
@samtsai samtsai changed the title fix: issue 27216 fast glob error fix(grep): fix options sent to fast glob package - issue 27216 Jul 7, 2023
@samtsai
Copy link
Contributor Author

samtsai commented Jul 7, 2023

@jordanpowell88 @emilyrohrbough could I get eyes on this PR?

@samtsai
Copy link
Contributor Author

samtsai commented Jul 11, 2023

@zedconte do you have permissions to re-run checks for me?

@zedconte
Copy link

@samtsai unfortunately I don't

@quipo
Copy link

quipo commented Jul 19, 2023

any chance of getting this PR merged?

@samtsai
Copy link
Contributor Author

samtsai commented Aug 1, 2023

fast-glob reverted the breaking change:
https://github.com/mrmlnc/fast-glob/releases/tag/3.3.1

This is can probably be closed although it wouldn't hurt either way.

@dyang-debug
Copy link

fast-glob reverted the breaking change: https://github.com/mrmlnc/fast-glob/releases/tag/3.3.1

This is can probably be closed although it wouldn't hurt either way.

Probably not, they will reintroduce it in the future

So, in the next major release, we will reintroduce method implementations

@mschile mschile assigned mschile and unassigned cacieprins Oct 13, 2023
@jennifer-shehane jennifer-shehane merged commit 5a7eee5 into cypress-io:develop Oct 13, 2023
64 of 66 checks passed
@samtsai samtsai deleted the fix-issue-27216-fast-glob-error branch October 14, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin @cypress/grep 3.1.5 throwing Cypress configuration error on cypress run