feat: Passing --browser flag alone will launch after test selection

cli/CHANGELOG.md

@@ -11,6 +11,7 @@ _Released 6/4/2024_
 
 - Added support for [Next.js 14](https://nextjs.org/blog/next-14) for component testing. Addresses [#28185](https://github.com/cypress-io/cypress/issues/28185).
 - Added an `IGNORE_CHROME_PREFERENCES` environment variable to ignore Chrome preferences when launching Chrome. Addresses [#29330](https://github.com/cypress-io/cypress/issues/29330).
+- Passing the browser without the testing type (i.e. `cypress open --browser <browser-name-or-path>`) will now directly launch the browser after the testing type is selected. Addresses [#22003](https://github.com/cypress-io/cypress/issues/22003). Addressed in [#28538](https://github.com/cypress-io/cypress/pull/28538).
 
 **Bugfixes:**
 

packages/data-context/src/actions/ProjectActions.ts

@@ -89,6 +89,13 @@ type SetForceReconfigureProjectByTestingType = {
 const debug = debugLib('cypress:data-context:ProjectActions')
 
 export class ProjectActions {
+  /**
+   * @var globalLaunchCount
+   * Used as a read-only in the launchpad to ensure
+   * that launchProject is only called once if
+   * the --browser flag is passed alone.
+   */
+  private globalLaunchCount = 0
   constructor (private ctx: DataContext) {}
 
   private get api () {
@@ -127,6 +134,14 @@ export class ProjectActions {
     })
   }
 
+  get launchCount () {
+    return this.globalLaunchCount
+  }
+
+  set launchCount (count) {
+    this.globalLaunchCount = count
+  }
+
   openDirectoryInIDE (projectPath: string) {
     this.ctx.debug(`opening ${projectPath} in ${this.ctx.coreData.localSettings.preferences.preferredEditorBinary}`)
 
@@ -284,6 +299,7 @@ export class ProjectActions {
     }
 
     await this.api.launchProject(browser, activeSpec ?? emptySpec, options)
+    this.globalLaunchCount++
 
     return
   }

packages/graphql/schemas/schema.graphql

@@ -1431,8 +1431,14 @@ type LocalSettingsPreferences {
   debugSlideshowComplete: Boolean
   desktopNotificationsEnabled: Boolean
   dismissNotificationBannerUntil: DateTime
+
+  """
+  A launch count to keep track of launchProject calls from projectActions
+  """
+  globalLaunchCount: Int
   isSideNavigationOpen: Boolean
   isSpecsListOpen: Boolean
+  isValidBrowser: Boolean
   majorVersionWelcomeDismissed: JSON
   notifyWhenRunCompletes: JSON
   notifyWhenRunStarts: Boolean

packages/graphql/src/schemaTypes/objectTypes/gql-LocalSettings.ts

@@ -33,6 +33,28 @@ export const LocalSettingsPreferences = objectType({
       },
     })
 
+    t.boolean('isValidBrowser', {
+      resolve: async (_source, _args, ctx) => {
+        try {
+          if (!ctx.coreData.cliBrowser) {
+            return false
+          }
+
+          const browser = await ctx._apis.browserApi.ensureAndGetByNameOrPath(ctx.coreData.cliBrowser)
+
+          return Boolean(browser)
+        } catch (e) {
+          // if error is thrown browser doesn't exist
+          return false
+        }
+      },
+    })
+
+    t.int('globalLaunchCount', {
+      description: 'A launch count to keep track of launchProject calls from projectActions',
+      resolve: (_source, _args, ctx) => ctx.actions.project.launchCount,
+    })
+
     t.boolean('debugSlideshowComplete')
     t.boolean('desktopNotificationsEnabled')
     t.dateTime('dismissNotificationBannerUntil')

packages/launchpad/cypress/e2e/choose-a-browser.cy.ts

@@ -1,6 +1,12 @@
 import type { FoundBrowser } from '@packages/types'
 
 describe('Choose a browser page', () => {
+  before(() => {
+    cy.withCtx((ctx, _) => {
+      ctx.actions.project.launchCount = 0
+    })
+  })
+
   beforeEach(() => {
     cy.scaffoldProject('launchpad')
   })
@@ -14,6 +20,24 @@ describe('Choose a browser page', () => {
       })
     })
 
+    it('launches when --browser is passed alone through the command line', () => {
+      cy.withCtx((ctx, o) => {
+        o.sinon.stub(ctx._apis.projectApi, 'launchProject').resolves()
+      })
+
+      cy.openProject('launchpad', ['--browser', 'edge'])
+      cy.visitLaunchpad()
+
+      cy.skipWelcome()
+      cy.get('[data-cy=card]').then(($buttons) => {
+        $buttons[0].click()
+      })
+
+      cy.withRetryableCtx((ctx, o) => {
+        expect(ctx._apis.projectApi.launchProject).to.be.calledOnce
+      })
+    })
+
     it('preselects browser that is provided through the command line', () => {
       cy.withCtx((ctx, o) => {
         // stub launching project since we have `--browser --testingType --project` here

packages/launchpad/src/setup/OpenBrowser.vue

@@ -22,7 +22,7 @@
 import { useMutation, gql, useQuery } from '@urql/vue'
 import OpenBrowserList from './OpenBrowserList.vue'
 import WarningList from '../warning/WarningList.vue'
-import { OpenBrowserDocument, OpenBrowser_CloseBrowserDocument, OpenBrowser_ClearTestingTypeDocument, OpenBrowser_LaunchProjectDocument, OpenBrowser_FocusActiveBrowserWindowDocument, OpenBrowser_ResetLatestVersionTelemetryDocument } from '../generated/graphql'
+import { OpenBrowserDocument, OpenBrowser_CloseBrowserDocument, OpenBrowser_ClearTestingTypeDocument, OpenBrowser_LaunchProjectDocument, OpenBrowser_FocusActiveBrowserWindowDocument, OpenBrowser_ResetLatestVersionTelemetryDocument, OpenBrowser_LocalSettingsDocument } from '../generated/graphql'
 import LaunchpadHeader from './LaunchpadHeader.vue'
 import { useI18n } from '@cy/i18n'
 import { computed, ref, onMounted } from 'vue'
@@ -42,7 +42,20 @@ query OpenBrowser {
 }
 `
 
+gql`
+query OpenBrowser_LocalSettings {
+  localSettings {
+    preferences {
+      wasBrowserSetInCLI
+      isValidBrowser
+      globalLaunchCount
+    }
+  }
+}
+`
+
 const query = useQuery({ query: OpenBrowserDocument })
+const lsQuery = useQuery({ query: OpenBrowser_LocalSettingsDocument, requestPolicy: 'network-only' })
 
 gql`
 mutation OpenBrowser_ClearTestingType {
@@ -106,6 +119,19 @@ const launch = async () => {
   }
 }
 
+const launchIfBrowserSetInCli = async () => {
+  await lsQuery
+  const isValidBrowser = lsQuery.data.value?.localSettings.preferences.isValidBrowser
+  const wasBrowserSetInCli = lsQuery.data.value?.localSettings.preferences.wasBrowserSetInCLI
+  const globalLaunchCount = lsQuery.data.value?.localSettings.preferences.globalLaunchCount
+
+  if (wasBrowserSetInCli && isValidBrowser && (globalLaunchCount === 0)) {
+    await launch()
+  }
+
+  return
+}
+
 const backFn = () => {
   clearCurrentTestingType.executeMutation({})
 }
@@ -126,6 +152,7 @@ const setFocusToActiveBrowserWindow = () => {
 
 onMounted(() => {
   resetLatestVersionTelemetry.executeMutation({})
+  launchIfBrowserSetInCli()
 })
 
 </script>