Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct cy.screenshot's fullpage behavior #28930

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Feb 13, 2024

Additional details

Steps to test

How has the user experience changed?

PR Tasks

@emilyrohrbough emilyrohrbough changed the title Issue 27260 fix: correct fullscreen screenshot scroll behavior Feb 13, 2024
@emilyrohrbough emilyrohrbough changed the title fix: correct fullscreen screenshot scroll behavior fix: correct fullpage screenshot scroll behavior Feb 13, 2024
@emilyrohrbough emilyrohrbough changed the title fix: correct fullpage screenshot scroll behavior fix: correct cy.screenshot's fullpage behavior Feb 13, 2024
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Feb 13, 2024
Copy link

cypress bot commented Feb 13, 2024

53 failed and 11 flaky tests on run #53994 ↗︎

53 16525 824 0 Flakiness 11

Details:

Merge branch 'develop' into issue-27260
Project: cypress Commit: adbbc2eb22
Status: Failed Duration: 19:56 💡
Started: Feb 13, 2024 2:48 PM Ended: Feb 13, 2024 3:08 PM
Failed  dom/visibility.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  e2e/origin/commands/screenshot.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  commands/screenshot.cy.js • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  e2e/origin/commands/navigation.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts
Failed  e2e/origin/patches.cy.ts • 0 failed tests • 5x-driver-electron

View Output

Test Artifacts

The first 5 failed specs are shown, see all 881 specs in Cypress Cloud.

Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > #consoleProps with an intercept alias Test Replay
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
... > can be opened Test Replay Screenshots
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
... > intercept aliases > returns an array of xhrs when dots in alias name
    </td>
  </tr></table>
Flakiness  e2e/origin/commands/screenshot.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test Artifacts
cy.origin screenshot > without setting viewport > handles errors thrown from setTimeout when the timer is NOT paused
    </td>
  </tr></table>

The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.

Review all test suite changes for PR #28930 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
2 participants