Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue-22732-add-check-CI-browser-value #29188

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

lunaautomation
Copy link

Additional details

Resolves the issue where a user doesn't specify a browser and the check ignores the null value passed.

Steps to test

Run the steps to reproduce on the issue, providing a CI run command with the browser tag and a null value.

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@lunaautomation lunaautomation changed the title fix: add check for CI browser value and test issue-22732-add-check-CI-browser-value Mar 22, 2024
@lunaautomation lunaautomation changed the title issue-22732-add-check-CI-browser-value fix: issue-22732-add-check-CI-browser-value Mar 22, 2024
@jennifer-shehane
Copy link
Member

@lunaautomation Thanks for the contribution! Could you please sign our CLA?

@lunaautomation
Copy link
Author

@jennifer-shehane
I've tried writing a test for the fix but I get the following error when it runs
Error: The context has already been set. If this is occurring in a testing context, make sure you are clearing the context. Otherwise

I am not sure what the issue is here?

@jennifer-shehane
Copy link
Member

@lunaautomation Have you allowed access for maintainers to edit?
Screenshot 2024-04-16 at 2 31 59 PM

@jennifer-shehane
Copy link
Member

@lunaautomation Are you able to look at this? We'll have to close this PR if the previous comments aren't addressed.

@lunaautomation
Copy link
Author

Hi @jennifer-shehane
I think because this originated from my orgs fork it's not showing that option when I go to edit the PR. I can attempt to open a new one but I don't know if I'll see the option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress encountered an error while parsing the argument: --spec
4 participants