New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: --spec now allows () in filename #29279
base: develop
Are you sure you want to change the base?
fix: --spec now allows () in filename #29279
Conversation
|
Is there anything I should do since the check for ''Semantic Pull Request'' is failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to escape parenthesis in all cases in cypress. the --spec
arg can support glob patterns and parenthesis are a valid glob pattern, but I haven't been able to get glob patterns outside of wildcards to work correctly. @jennifer-shehane do you have more knowledge on what's expected? I mainly going off of https://docs.cypress.io/guides/guides/command-line#cypress-run-spec-lt-spec-gt and testing with the CLI and using https://globster.xyz/
Co-authored-by: Bill Glesias <bglesias@gmail.com>
@AtofStryker That's a good call out. This bug only happens when you have a closing paren DIRECTLY following an opening paren, so |
@jennifer-shehane is the failure in CI legit in relation to the glob changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasTeixeira2003 There does appear to be a snapshot that has changed with globs - that is failing here. Can you take a look: https://app.circleci.com/pipelines/github/cypress-io/cypress/60955/workflows/e499d77f-ccf3-4aba-8f7f-ed00d2595ba1/jobs/2535654
I will look into it today |
@tomasbjerre Any chance to look at this? |
@jennifer-shehane you probably tagged the wrong Tomas. But I think it looks great :) |
Sorry @TomasTeixeira2003 Any chance to look at this? |
I'm sorry, have had a lot of work lately. By tomorrow I will check it. |
Additional details
Even though there was an existing workaround, it is easier to just allow parenthesis.
PR Tasks
cypress-documentation
?type definitions
?