Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulated mouse fixes, rightclick, dblclick #3030

Merged
merged 59 commits into from
Oct 11, 2019
Merged

simulated mouse fixes, rightclick, dblclick #3030

merged 59 commits into from
Oct 11, 2019

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Dec 28, 2018

mouse events

mouse events added in this PR:

+ pointerup
+ pointerdown
+ pointermove
+ pointerover
+ pointerenter
+ pointerleave
+ pointerout
mouseup
mousedown
+ mousemove
+ mouseover
+ mouseenter
+ mouseleave
+ mouseout
click
dblclick
+ contextmenu

right click, double click

trigger

tasks

  • pointer events
  • console log shows all events
  • fix dblclick
  • right click
  • send selectionchange event on document browser already does this even when out of focus
  • add test for clicking inside iframe
  • fix coords incorrect when clicking inside iframe
  • waiting on fix for Cypress reads Window.length as number of subjects passed from cy.window()  #4396
  • typedefs
  • fix messed up console table of events
  • add test for cy.click checking checkboxes
  • add comment for element-moving-during-click algorithm
  • refactor action commands to reuse click logic
  • add fromAutWindow positional coords for red hitbox
  • add test for iframe red hitbox coords

non-blocking tasks

Guide for review

  • review console messages during cy.click, cy.dblclick, and cy.rightclick
  • make sure tests cover all use cases of dblclick and rightclick
  • let me know if I missed an issue this fixes

User facing changes:

API:

  • add cy.rightclick()

typedefs changes:

  • add cy.rightclick() typedef

UX:

  • console messages when pinning click command has more information:
    image
    warning messaging in table:
    image
    no mouse move events needed:
    image

@kuceb kuceb changed the title WIP Issue 2957 WIP Issue 2956 Jan 2, 2019
@kuceb kuceb mentioned this pull request Jan 3, 2019
@kuceb kuceb force-pushed the issue-2957 branch 3 times, most recently from a3e9664 to 7db89d6 Compare January 15, 2019 19:21
@kuceb kuceb changed the title WIP Issue 2956 WIP synthetic mouse events fixes Jan 15, 2019
@kuceb kuceb changed the title WIP synthetic mouse events fixes synthetic mouse events fixes Feb 4, 2019
@kuceb kuceb requested a review from brian-mann February 4, 2019 16:33
@kuceb kuceb changed the base branch from develop to v3.2.0 February 4, 2019 16:37
@kuceb kuceb changed the title synthetic mouse events fixes WIP: synthetic mouse events fixes Feb 4, 2019
@kuceb
Copy link
Contributor Author

kuceb commented Feb 4, 2019

WIP going back on for dblclick and rightclick changes

@kuceb kuceb changed the title WIP: synthetic mouse events fixes synthetic mouse events fixes Feb 13, 2019
@kuceb kuceb reopened this May 20, 2019
@jennifer-shehane jennifer-shehane changed the base branch from v3.2.0 to develop May 24, 2019 06:13
@jennifer-shehane
Copy link
Member

Changed the base to develop, is this still WIP since there's a checkbox not checked?

@kuceb
Copy link
Contributor Author

kuceb commented May 24, 2019

It's in a reviewable state, but I do still have one task to do

@kuceb kuceb requested a review from brian-mann October 7, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment