Corrected spinner animation

[ranbena]

	Demo
❌ Before ✅ After

The bug

fa-spinner was not meant to spin smoothly but in steps.

And this is important because why? 🙄

I work a lot with Cypress and it's hurting my eyes and crushing my soul! 😱😵😖😭

The fix

Changed to the dedicated 8 step fa-pulse animation.

Tested?

Nope. But it looks riskless 😅

[CLAassistant]

All committers have signed the CLA.

[flotwig]

Thanks for the PR!

[kuceb]

@ranbena I see where you're coming from, but if you look at
https://fontawesome.com/v4.7.0/examples/

there are multiple examples of fa-spinner with fa-spin

I have no preference

[kuceb]

@ranbena Here's how you can add this today. In support/index.js do:

addGlobalStyle(`
.fa-spinner.fa-spin {
	animation: fa-spin 1s infinite steps(8)
}
`)

function addGlobalStyle(css) {
  var head, style
  head = window.top.document.getElementsByTagName('head')[0]
  if (!head) {
    return
  }
  style = window.top.document.createElement('style')
  style.type = 'text/css'
  style.innerHTML = css
  head.appendChild(style)
}

[ranbena]

@ranbena Here's how you can add this today. In support/index.js do:

addGlobalStyle(`
.fa-spinner.fa-spin {
	animation: fa-spin 1s infinite steps(8)
}
`)

Hehe 10x @bkucera :)