Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ansi_up to version .x 🌟 #4331

Merged
merged 9 commits into from Dec 20, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2019

This PR contains the following updates:

Package Type Update Change References
ansi_up dependencies major 1.3.0 -> 4.0.3 source

Release Notes

drudru/ansi_up

v4.0.3

Compare Source

Now supports escaped URL support - or 'terminal links' #​51
This is the proper solution to displaying URLs in a terminal.

Additional bug fixes were also merged in.

v4.0.2

Compare Source

v3.0.0

Compare Source

Now has proper Bold support.
Bug fixes and pull requests merged.

v2.0.3

Compare Source

v2.0.2

Compare Source

Bug fix from #​42 - fix the UMD support for webpack

v2.0.1

Compare Source

Bug fix from #​41 - adds support for another ANSI CSI code.

v2.0.0

Compare Source


Renovate configuration

πŸ“… Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels May 29, 2019
@renovate
Copy link
Contributor Author

renovate bot commented May 30, 2019

PR has been edited

πŸ‘· This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 30, 2019

@brian-mann Honestly, I'm a little confused about the original intent of the ansi_to_html, is it supposed to have the ansi-* classes? Because the tests are failing, expecting RGB colors, but...we pass the use_classes option (which I think was never working in our ansi_up version).

https://github.com/cypress-io/cypress/blob/renovate/ansi_up-4.x/packages/server/lib/errors.coffee#L820

So, should the test change or the code change? The Dashboard app has stylings for ansi-* classes.

Edit: I'm confused by what I wrote here, the test is failing due to the opposite.

@jennifer-shehane jennifer-shehane added the stage: needs review The PR code is done & tested, needs review label Jul 3, 2019
@cypress
Copy link

cypress bot commented Oct 2, 2019



Test summary

3587 β€’ 0 β€’ 47 β€’ 0


Run details

Project cypress
Status Passed
Commit f36def1
Started Dec 20, 2019 11:20 AM
Ended Dec 20, 2019 11:24 AM
Duration 04:29 πŸ’‘
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➑️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is good now. Fixed the failing test by properly setting the class options

@jennifer-shehane jennifer-shehane merged commit c3ad1a3 into develop Dec 20, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2019

Released in 3.8.1.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants