Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cy.visit slowness by removing Electron timers workaround #4385

Merged
merged 28 commits into from
Jun 17, 2019
Merged

Fix cy.visit slowness by removing Electron timers workaround #4385

merged 28 commits into from
Jun 17, 2019

Commits on Jun 3, 2019

  1. add tests for getAddress on localhost

    @flotwig
    flotwig committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    3d82220 View commit details
    Browse the repository at this point in the history

  2. add test for visit resolving quickly

    @flotwig
    flotwig committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    925efeb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. add debug logs to network

    @flotwig
    flotwig committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    5f678a2 View commit details
    Browse the repository at this point in the history

  2. network: override addRequest in HttpAgent, not createSocket

    @flotwig
    flotwig committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    768381b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. don't need to add connection: keep-alive to all responses 

    #4385 (comment)
    @flotwig
    flotwig committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    79edfa5 View commit details
    Browse the repository at this point in the history

  2. test that visit finishes quickly

    @flotwig
    flotwig committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    6083e1e View commit details
    Browse the repository at this point in the history

  3. do not forward connection header

    @flotwig
    flotwig committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    600c9c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. add tests to help reproduce

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    108d6b6 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    625d4ec View commit details
    Browse the repository at this point in the history

  3. still send keep-alive

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    5d67a97 View commit details
    Browse the repository at this point in the history

  4. update tests

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    07a8258 View commit details
    Browse the repository at this point in the history

  5. remove timers

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    b9d65a4 View commit details
    Browse the repository at this point in the history

  6. add snapshots to e2e test

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    208775a View commit details
    Browse the repository at this point in the history

  7. remove tests for debugging

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    ebe4310 View commit details
    Browse the repository at this point in the history

  8. try making console writes async

    @flotwig
    flotwig committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    9c8337e View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Revert "remove timers" 

    This reverts commit b9d65a4.
    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    93f15fc View commit details
    Browse the repository at this point in the history

  2. allow DEBUG_COLORS to be passed in an e2e test

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    aee8a72 View commit details
    Browse the repository at this point in the history

  3. try: using system node for the timers, setting up our own IPC

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    c51b395 View commit details
    Browse the repository at this point in the history

  4. Revert "try: using system node for the timers, setting up our own IPC" 

    This reverts commit c51b395.
    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    d507f52 View commit details
    Browse the repository at this point in the history

  5. put the interesting test first

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    1b14a1b View commit details
    Browse the repository at this point in the history

  6. use electron-mocha to run tests in electron

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    8b82f0e View commit details
    Browse the repository at this point in the history

  7. Revert "use electron-mocha to run tests in electron" 

    This reverts commit 8b82f0e.
    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    ae439aa View commit details
    Browse the repository at this point in the history

  8. support legacy addRequest invocation

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    890e38a View commit details
    Browse the repository at this point in the history

  9. Revert "Revert "remove timers"" 

    This reverts commit 93f15fc.
    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    3f077f8 View commit details
    Browse the repository at this point in the history

  10. update snapshot

    @flotwig
    flotwig committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    2858a5b View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Revert "try making console writes async" 

    This reverts commit 9c8337e.
    @flotwig
    flotwig committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    47860ca View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into issue-4313

    @flotwig
    flotwig committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    8e63476 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. complete in 150ms, not 1000ms

    @flotwig
    flotwig committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    bbff24d View commit details
    Browse the repository at this point in the history