Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when Cypress detects policies that may interfere with automating Chrome #4405

Merged
merged 19 commits into from Jul 3, 2019

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 6, 2019

Fixes #4391

Warning in run mode (only if they're using a Chrome-family browser):

Cypress detected policy settings on your computer that may cause issues. 

The following policies were detected that may prevent Cypress from automating Chrome: 

 > HKEY_LOCAL_MACHINE\Software\Policies\Google\Chrome\ProxyMode 

For more information, see https://on.cypress.io/bad-browser-policy

Tooltip warning

image

@flotwig flotwig changed the title add chrome policy check that is logged to stdout/displayed in GUI [WIP] Warn when Cypress detects policies that may interfere with automating Chrome Jun 6, 2019
@flotwig flotwig changed the title [WIP] Warn when Cypress detects policies that may interfere with automating Chrome Warn when Cypress detects policies that may interfere with automating Chrome Jun 7, 2019
@flotwig flotwig requested a review from a team June 7, 2019 18:32
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The on link should be a direct link run through https://github.com/cypress-io/cypress-services/blob/develop/packages/on/data/links.yml#L60, not the link + hash

@flotwig
Copy link
Contributor Author

flotwig commented Jun 10, 2019

@jennifer-shehane I've updated it to https://on.cypress.io/bad-browser-policy , just not in the screenshots.

@jennifer-shehane jennifer-shehane requested a review from a team June 11, 2019 06:51
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't manually test though.

@flotwig flotwig changed the title Warn when Cypress detects policies that may interfere with automating Chrome [WIP] Warn when Cypress detects policies that may interfere with automating Chrome Jun 11, 2019
@wojciechsabaj
Copy link

Hi, great job!

In my opinion, the balloon tip will be enough when you move the content from yellow warning message to the balloon tip.

If you insist on leaving the yellow warning message, please make it more condensed, as the version presented on screenshots contains unnecessary newlines between sentences.

Keep working on Cypress! It's awesome, even with its limitations.

@flotwig flotwig changed the title [WIP] Warn when Cypress detects policies that may interfere with automating Chrome Warn when Cypress detects policies that may interfere with automating Chrome Jun 20, 2019
@flotwig flotwig requested a review from a team June 20, 2019 16:11
@flotwig flotwig mentioned this pull request Jun 26, 2019
"winston": "1.1.2"
},
"optionalDependencies": {
"@cypress/registry-js": "1.3.3-patch1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I was wondering why this PR didn't seem to be having any effect!

@flotwig flotwig deleted the issue-4391 branch January 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when ProxyMode/ExtensionWhiteList registry setting is detected
4 participants