reporter: Cache aliasesWithDuplicates to prevent unnecessary re-renders, fixes UI slowdown #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
commented
Jun 24, 2019
| // do a deep compare here to see if we can use the cached aliases, which will allow mobx's | ||
| // @computed identity comparison to pass, preventing unnecessary re-renders | ||
| // https://github.com/cypress-io/cypress/issues/4411 | ||
| if (!_.isEqual(aliasesWithDuplicates, this._aliasesWithDuplicatesCache)) { |
There was a problem hiding this comment.
I wanted to use comparer.structural instead of doing this with lodash (https://mobx.js.org/refguide/computed-decorator.html#builtin-comparers) but it doesn't seem to accomplish the same thing.
brian-mann
requested changes
Jun 24, 2019
brian-mann
approved these changes
Jun 24, 2019
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4411
Brings total Command re-renders down to 407 from 80,000+