Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore garbage render worker errors coming from electron #4644

Merged
merged 2 commits into from Jul 3, 2019
Merged

ignore garbage render worker errors coming from electron #4644

merged 2 commits into from Jul 3, 2019

Conversation

brian-mann
Copy link
Member

fixes #4288

@jennifer-shehane jennifer-shehane self-requested a review July 3, 2019 10:29
jennifer-shehane
jennifer-shehane previously approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warnings seem to have disappeared for me. Testing on develop - warning showed up, switched to this branch - warning disappears.

Do we want to hide the runnings completely and forever? What about when running in DEBUG mode?

@brian-mann
Copy link
Member Author

These are not part of electrons debugging subsystem - they are generated by Chromium as errors/warnings for who knows what reason.

@brian-mann brian-mann changed the title WIP: ignore garbage render worker errors coming from electron ignore garbage render worker errors coming from electron Jul 3, 2019
@brian-mann brian-mann merged commit 93b3eda into develop Jul 3, 2019
@cypress-bot cypress-bot bot mentioned this pull request Jul 3, 2019
Closed
@flotwig flotwig mentioned this pull request Jan 29, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headless run dumps heaps of GL errors in the terminal
2 participants
@brian-mann @jennifer-shehane