[WIP] fix(driver:keyboard): fix typing negative numbers with existing text … #4768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
requested changes
Jul 23, 2019
| @@ -575,9 +580,11 @@ const $Keyboard = { | |||
| return | |||
| } | |||
|
|
|||
| const isFirstSymbol = !valueLength || (selectionLength === valueLength) | |||
|
|
|||
| //# only type '.' and '-' if it is the first symbol and there already is a value, or if | |||
| //# '.' or '-' are appended to a digit. If not, value cannot be set. | |||
There was a problem hiding this comment.
I think there may be some missing logic still to match the spec - notably allowing e, E, and +. Also - I'd like a link to the spec in the comments if possible because otherwise I'm just like - where did this logic definition even come from?
- value allows floating point number https://www.w3.org/TR/2010/WD-html-markup-20101019/input.number.html#input.number.attrs.value
- floating point number definition https://www.w3.org/TR/2010/WD-html-markup-20101019/datatypes.html#common.data.float
jennifer-shehane
changed the title
|
Going to close this and put these changes in upcoming simulated type fixes PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow typing minus(
-) sign into number field if entire field is selectedfix cannot
typenegative number into number input with text selection #4767link to w3 spec
allow scientific notation numbers e.g.
1e9