Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop GUI layout issues/improvements #4905

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 1, 2019

Pre-merge Tasks

  • Have tests been added/updated for the changes in this PR?
  • Has the original issue been tagged with a release in ZenHub?

@chrisbreiding chrisbreiding requested a review from a team August 1, 2019 19:43
@cypress
Copy link

cypress bot commented Aug 1, 2019



Test summary

3324 0 47 1


Run details

Project cypress
Status Passed
Commit b512bde
Started Aug 1, 2019 7:47 PM
Ended Aug 1, 2019 7:52 PM
Duration 04:14 💡
OS Linux Debian - 8.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@brian-mann brian-mann merged commit 71036d5 into develop Aug 1, 2019
flotwig added a commit that referenced this pull request Aug 20, 2019
turns out the behavior #4905 relies upon was broken by a Chrome update
more info: https://stackoverflow.com/a/29909047/3474615
@flotwig flotwig mentioned this pull request Aug 20, 2019
grabartley pushed a commit to grabartley/cypress that referenced this pull request Oct 6, 2019
* dry up project mode spec

* fix desktop-gui footer being at top when loading project

* fix update banner covering last spec

* only scroll specs and leave filter in place
@chrisbreiding chrisbreiding deleted the issue-4888-desktop-gui-layout-issues branch April 5, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants