Fix async timeouts #5097
Merged
Fix async timeouts #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
requested changes
Sep 25, 2019
packages/driver/test/cypress/integration/cypress/runner_spec.js
Outdated
Show resolved
Hide resolved
jennifer-shehane
approved these changes
Sep 26, 2019
|
Does this PR also fix #4742 ? |
grabartley
pushed a commit
to grabartley/cypress
that referenced
this pull request
Oct 6, 2019
* fix async timeouts * add tests * add asyncTestTimeout config value * fix angular_spec, add timeout test * fix connectors_spec * fix querying_spec * fix e2e test e2e_config_fails * fix e2e specs, change calls to cy.timeout() * remove added config value, use `defaultCommandTimeout` * fix timing out internal tests * cleanup * add e2e test for async timeout after cy command * [review] remove most of runner_spec * add back runner_spec, whoops
Closed
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix async tests with
donecallbacks never timing out after cypress commandadd config value forasyncTestTimeout(default4000)user facing changes
donecallback will now timeout afterdefaultCommandTimeoutafter all commands have runtasks
defaultCommandTimeoutasasyncTestTimeout(for now)Pre-merge Tasks