-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: remove any leftover double quotes from group and ci build id #5692
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
group: dequote, | ||
ciBuildId: dequote, | ||
} | ||
const cleanOpts = R.evolve(removeQuotes, opts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason not to apply this treatment to all of the CLI args? it's a little weird that we treat quotes specially for these 2 but not others
so the rest of these are easy to spot when they go wrong. But these two are
NOT obvious to the user - they are sent to the API and then ... you just
get a split test run for example, which you have no idea or control over.
If someone can show me a problem with other arguments - I am all for it,
but for now I would be loathe to change more logic without a reason
…On Thu, Nov 14, 2019 at 3:51 PM Zach Bloomquist ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cli/lib/util.js
<#5692 (comment)>:
> + 'parallel',
+ 'group',
+ 'ciBuildId'
+ )
+
+ if (opts.exit) {
+ opts = _.omit(opts, 'exit')
+ }
+
+ // some options might be quoted - which leads to unexpected results
+ // remove double quotes from certain options
+ const removeQuotes = {
+ group: dequote,
+ ciBuildId: dequote,
+ }
+ const cleanOpts = R.evolve(removeQuotes, opts)
is there a reason not to apply this treatment to all of the CLI args? it's
a little weird that we treat quotes specially for these 2 but not others
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5692?email_source=notifications&email_token=AAQ4BJWE7H3W6CVLA3SADKTQTW265A5CNFSM4JM6TKVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLUOBJA#pullrequestreview-317251748>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ4BJRH5EDXTNZV6HOTZGDQTW265ANCNFSM4JM6TKVA>
.
--
Dr. Gleb Bahmutov, PhD
Schedule video chat / phone call / meeting with me via
https://calendly.com/bahmutov
gleb.bahmutov@gmail.com @bahmutov <https://twitter.com/@bahmutov>
https://glebbahmutov.com/ https://glebbahmutov.com/blog
https://github.com/bahmutov
|
User facing changelog
You can run
cypress run --ci-build-id "123" --group "staging"
and it will automatically strip double quotes fromciBuildId
andgroup
parametersAdditional details
I have noticed unexpected ci build id and group names which moved Windows runs into separate Dashboard runs in cypress-io/github-action#5
How has the user experience changed?
One more less thing to worry about due to OS differences
PR Tasks